diff options
author | Tom Gundersen <teg@jklm.no> | 2016-09-21 14:59:19 (GMT) |
---|---|---|
committer | Sean Paul <seanpaul@chromium.org> | 2016-09-22 11:03:48 (GMT) |
commit | 0f2886057be322ddfa4858384c40a505f7a32a4a (patch) | |
tree | 95fd93e32cce031f99920cd1937b4e46491e65b3 /drivers/gpu/drm/nouveau | |
parent | c6bf811a0b55ab224fb2c75345641b4bb599475c (diff) | |
download | linux-0f2886057be322ddfa4858384c40a505f7a32a4a.tar.xz |
drm: Don't swallow error codes in drm_dev_alloc()
There are many reasons other than ENOMEM that drm_dev_init() can
fail. Return ERR_PTR rather than NULL to be able to distinguish
these in the caller.
Signed-off-by: Tom Gundersen <teg@jklm.no>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: http://patchwork.freedesktop.org/patch/msgid/20160921145919.13754-2-teg@jklm.no
Diffstat (limited to 'drivers/gpu/drm/nouveau')
-rw-r--r-- | drivers/gpu/drm/nouveau/nouveau_drm.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c index 652ab11..3100fd88 100644 --- a/drivers/gpu/drm/nouveau/nouveau_drm.c +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c @@ -1067,8 +1067,8 @@ nouveau_platform_device_create(const struct nvkm_device_tegra_func *func, goto err_free; drm = drm_dev_alloc(&driver_platform, &pdev->dev); - if (!drm) { - err = -ENOMEM; + if (IS_ERR(drm)) { + err = PTR_ERR(drm); goto err_free; } |