diff options
author | adam radford <aradford@gmail.com> | 2012-01-11 02:07:56 (GMT) |
---|---|---|
committer | James Bottomley <JBottomley@Parallels.com> | 2012-01-16 08:28:03 (GMT) |
commit | 124dd90f6525ee785b47b59aebadd4a35f797dc1 (patch) | |
tree | de46f5d335a05c198567ae3d7b2a9a212fd04006 /drivers/hid/hid-chicony.c | |
parent | 7e95fffe080d4dbe826dfe864eb084916cdc6468 (diff) | |
download | linux-124dd90f6525ee785b47b59aebadd4a35f797dc1.tar.xz |
[SCSI] megaraid: fix sparse warnings
There's a zero day mistake in the megaraid driver in that the code that
obtains the version number does a >> 8 on a char quantity. This >>8 causes a
sparse warning because it always produces zero. Al Viro suggested these
shifts should be >> 4 thus treating the firmware version as a BCD quantity.
However, in the interests of safety we've elected to replace the >> 8
quantities with an explicit zero, thus quieting the sparse warning while
preserving the same (albeit incorrect) version number as had previously been
seen.
Signed-off-by: Adam Radford <aradford@gmail.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'drivers/hid/hid-chicony.c')
0 files changed, 0 insertions, 0 deletions