summaryrefslogtreecommitdiff
path: root/drivers/md/bitmap.c
diff options
context:
space:
mode:
authorNeilBrown <neilb@suse.com>2015-07-23 23:22:16 (GMT)
committerNeilBrown <neilb@suse.com>2015-07-24 03:37:21 (GMT)
commit34cab6f42003cb06f48f86a86652984dec338ae9 (patch)
tree246eafb8c7a8cf3bea39234e56cca7a5cfe09d21 /drivers/md/bitmap.c
parentd3b178adb3a3adf54ecf77758138b654c3ee7f09 (diff)
downloadlinux-34cab6f42003cb06f48f86a86652984dec338ae9.tar.xz
md/raid1: fix test for 'was read error from last working device'.
When we get a read error from the last working device, we don't try to repair it, and don't fail the device. We simple report a read error to the caller. However the current test for 'is this the last working device' is wrong. When there is only one fully working device, it assumes that a non-faulty device is that device. However a spare which is rebuilding would be non-faulty but so not the only working device. So change the test from "!Faulty" to "In_sync". If ->degraded says there is only one fully working device and this device is in_sync, this must be the one. This bug has existed since we allowed read_balance to read from a recovering spare in v3.0 Reported-and-tested-by: Alexander Lyakas <alex.bolshoy@gmail.com> Fixes: 76073054c95b ("md/raid1: clean up read_balance.") Cc: stable@vger.kernel.org (v3.0+) Signed-off-by: NeilBrown <neilb@suse.com>
Diffstat (limited to 'drivers/md/bitmap.c')
0 files changed, 0 insertions, 0 deletions