diff options
| author | Colin Ian King <colin.king@canonical.com> | 2015-07-23 15:47:59 (GMT) |
|---|---|---|
| committer | Mike Snitzer <snitzer@redhat.com> | 2015-07-27 11:58:15 (GMT) |
| commit | 134bf30c06f057d6b8d90132e8f8b3cd2be79572 (patch) | |
| tree | 18e54851abf6c3300448b933c150c802894f800b /drivers/md | |
| parent | 0a927c2f02a2437a57679527e42ab7cbfa14efb1 (diff) | |
| download | linux-134bf30c06f057d6b8d90132e8f8b3cd2be79572.tar.xz | |
dm cache policy smq: fix alloc_bitset check that always evaluates as false
static analysis by cppcheck has found a check on alloc_bitset that
always evaluates as false and hence never finds an allocation failure:
[drivers/md/dm-cache-policy-smq.c:1689]: (warning) Logical conjunction
always evaluates to false: !EXPR && EXPR.
Fix this by removing the incorrect mq->cache_hit_bits check
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Diffstat (limited to 'drivers/md')
| -rw-r--r-- | drivers/md/dm-cache-policy-smq.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/md/dm-cache-policy-smq.c b/drivers/md/dm-cache-policy-smq.c index b6f2265..48a4a82 100644 --- a/drivers/md/dm-cache-policy-smq.c +++ b/drivers/md/dm-cache-policy-smq.c @@ -1686,7 +1686,7 @@ static struct dm_cache_policy *smq_create(dm_cblock_t cache_size, if (from_cblock(cache_size)) { mq->cache_hit_bits = alloc_bitset(from_cblock(cache_size)); - if (!mq->cache_hit_bits && mq->cache_hit_bits) { + if (!mq->cache_hit_bits) { DMERR("couldn't allocate cache hit bitset"); goto bad_cache_hit_bits; } |