diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2016-01-06 10:05:52 (GMT) |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@osg.samsung.com> | 2016-02-01 09:59:43 (GMT) |
| commit | 39de7d95f88d95a07f64b047c985fff31c006b5c (patch) | |
| tree | d595c728e58c2d63f15f3d420d8ccdb53d81344b /drivers/media/i2c | |
| parent | 74dc385cb450089b28c28be2c8a0baca296b95f9 (diff) | |
| download | linux-39de7d95f88d95a07f64b047c985fff31c006b5c.tar.xz | |
[media] vpx3220: signedness bug in vpx3220_fp_read()
The intent was to return -1 on error and that's what the callers expect
but the current code returns USHRT_MAX instead.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Diffstat (limited to 'drivers/media/i2c')
| -rw-r--r-- | drivers/media/i2c/vpx3220.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/i2c/vpx3220.c b/drivers/media/i2c/vpx3220.c index 4b564f1..90b693f 100644 --- a/drivers/media/i2c/vpx3220.c +++ b/drivers/media/i2c/vpx3220.c @@ -124,7 +124,7 @@ static int vpx3220_fp_write(struct v4l2_subdev *sd, u8 fpaddr, u16 data) return 0; } -static u16 vpx3220_fp_read(struct v4l2_subdev *sd, u16 fpaddr) +static int vpx3220_fp_read(struct v4l2_subdev *sd, u16 fpaddr) { struct i2c_client *client = v4l2_get_subdevdata(sd); s16 data; |