diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2017-01-09 08:20:16 (GMT) |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-06-24 05:11:16 (GMT) |
| commit | f28ba80c6a3e8bf7ec96e06667dd82e98ae1c672 (patch) | |
| tree | fff16aa77dd9b218738f26eba554da394b06831a /drivers/misc | |
| parent | 02d009e865a830a16d932c4ea2fce158642c0bbe (diff) | |
| download | linux-f28ba80c6a3e8bf7ec96e06667dd82e98ae1c672.tar.xz | |
misc: mic: double free on ioctl error path
commit 816c9311f1144a03da1fdc4feb2f6b0d3299fca0 upstream.
This function only has one caller. Freeing "vdev" here leads to a use
after free bug. There are several other error paths in this function
but this is the only one which frees "vdev". It looks like the kfree()
can be safely removed.
Fixes: 61e9c905df78 ("misc: mic: Enable VOP host side functionality")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/misc')
| -rw-r--r-- | drivers/misc/mic/vop/vop_vringh.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/misc/mic/vop/vop_vringh.c b/drivers/misc/mic/vop/vop_vringh.c index 88e4523..fed992e 100644 --- a/drivers/misc/mic/vop/vop_vringh.c +++ b/drivers/misc/mic/vop/vop_vringh.c @@ -292,7 +292,6 @@ static int vop_virtio_add_device(struct vop_vdev *vdev, if (ret) { dev_err(vop_dev(vdev), "%s %d err %d\n", __func__, __LINE__, ret); - kfree(vdev); return ret; } |