diff options
| author | Boris Brezillon <boris.brezillon@free-electrons.com> | 2016-09-16 14:59:19 (GMT) |
|---|---|---|
| committer | Richard Weinberger <richard@nod.at> | 2016-10-02 20:48:14 (GMT) |
| commit | 7b6b749b125a93d673ba12977007dfbd65a61c32 (patch) | |
| tree | 75de2e3cad32f5d09b5799974cf1fcda113cde3b /drivers/mtd/ubi/ubi.h | |
| parent | 91f4285fe389a2729efcd5db642d7652d8f27a40 (diff) | |
| download | linux-7b6b749b125a93d673ba12977007dfbd65a61c32.tar.xz | |
UBI: move the global ech and vidh variables into struct ubi_attach_info
Even if it works fine with those global variables, attaching the
temporary ech and vidh objects used during UBI scan to the
ubi_attach_info object sounds like a more future-proof option.
For example, attaching several UBI devices in parallel is prevented by
this use of global variable. And also because global variables should
be avoided in general.
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
Diffstat (limited to 'drivers/mtd/ubi/ubi.h')
| -rw-r--r-- | drivers/mtd/ubi/ubi.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/mtd/ubi/ubi.h b/drivers/mtd/ubi/ubi.h index f22c6c2..b51d398 100644 --- a/drivers/mtd/ubi/ubi.h +++ b/drivers/mtd/ubi/ubi.h @@ -724,6 +724,8 @@ struct ubi_ainf_volume { * @ec_sum: a temporary variable used when calculating @mean_ec * @ec_count: a temporary variable used when calculating @mean_ec * @aeb_slab_cache: slab cache for &struct ubi_ainf_peb objects + * @ech: temporary EC header. Only available during scan + * @vidh: temporary VID header. Only available during scan * * This data structure contains the result of attaching an MTD device and may * be used by other UBI sub-systems to build final UBI data structures, further @@ -752,6 +754,8 @@ struct ubi_attach_info { uint64_t ec_sum; int ec_count; struct kmem_cache *aeb_slab_cache; + struct ubi_ec_hdr *ech; + struct ubi_vid_hdr *vidh; }; /** |