diff options
| author | Bruce Allan <bruce.w.allan@intel.com> | 2009-10-28 18:28:30 (GMT) |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-10-29 08:04:05 (GMT) |
| commit | 945eb31337c2a8a09a62dcf5aca260bcde9c2a6c (patch) | |
| tree | dc4e75d957da9a68267aec8b7078791bfb2d7407 /drivers/net/e1000e/ethtool.c | |
| parent | d6534799410d2b53e5e80b8a90d6a8bab3de30ed (diff) | |
| download | linux-945eb31337c2a8a09a62dcf5aca260bcde9c2a6c.tar.xz | |
e1000e: flow control doesn't re-enable
When changing flow control (pause) parameters, the flow control thresholds
(i.e. when to send XON/XOFF frames) may not be setup correctly on parts
with copper media. Call the existing e1000_set_fc_watermarks()
function to set these thresholds.
Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/e1000e/ethtool.c')
| -rw-r--r-- | drivers/net/e1000e/ethtool.c | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/drivers/net/e1000e/ethtool.c b/drivers/net/e1000e/ethtool.c index a70999b..0364b91 100644 --- a/drivers/net/e1000e/ethtool.c +++ b/drivers/net/e1000e/ethtool.c @@ -335,10 +335,18 @@ static int e1000_set_pauseparam(struct net_device *netdev, hw->fc.current_mode = hw->fc.requested_mode; - retval = ((hw->phy.media_type == e1000_media_type_fiber) ? - hw->mac.ops.setup_link(hw) : e1000e_force_mac_fc(hw)); + if (hw->phy.media_type == e1000_media_type_fiber) { + retval = hw->mac.ops.setup_link(hw); + /* implicit goto out */ + } else { + retval = e1000e_force_mac_fc(hw); + if (retval) + goto out; + e1000e_set_fc_watermarks(hw); + } } +out: clear_bit(__E1000_RESETTING, &adapter->state); return retval; } |