diff options
| author | Eric Dumazet <edumazet@google.com> | 2015-01-11 18:32:18 (GMT) |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-01-12 02:45:50 (GMT) |
| commit | 7a05dc64e2e4c611d89007b125b20c0d2a4d31a5 (patch) | |
| tree | 8f2d83bfb307b13055366662fc99d17538a05097 /drivers/net/ethernet/dnet.c | |
| parent | 12d80ac4e77265a89b87c3b80e2c9a7b29f7fdfb (diff) | |
| download | linux-7a05dc64e2e4c611d89007b125b20c0d2a4d31a5.tar.xz | |
alx: fix alx_poll()
Commit d75b1ade567f ("net: less interrupt masking in NAPI") uncovered
wrong alx_poll() behavior.
A NAPI poll() handler is supposed to return exactly the budget when/if
napi_complete() has not been called.
It is also supposed to return number of frames that were received, so
that netdev_budget can have a meaning.
Also, in case of TX pressure, we still have to dequeue received
packets : alx_clean_rx_irq() has to be called even if
alx_clean_tx_irq(alx) returns false, otherwise device is half duplex.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Fixes: d75b1ade567f ("net: less interrupt masking in NAPI")
Reported-by: Oded Gabbay <oded.gabbay@amd.com>
Bisected-by: Oded Gabbay <oded.gabbay@amd.com>
Tested-by: Oded Gabbay <oded.gabbay@amd.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/dnet.c')
0 files changed, 0 insertions, 0 deletions