diff options
| author | Eli Cohen <eli@dev.mellanox.co.il> | 2014-10-23 12:57:26 (GMT) |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-10-27 02:46:03 (GMT) |
| commit | 96e4be06cbfcb8c9c2da7c77bacce0e56b581c0b (patch) | |
| tree | de0c84c82bd7cb6f14343310d759163bdce6988a /drivers/net/ethernet/mellanox/mlx5/core/eq.c | |
| parent | b71e821de50f0ff92f10f33064ee1713e9014158 (diff) | |
| download | linux-96e4be06cbfcb8c9c2da7c77bacce0e56b581c0b.tar.xz | |
net/mlx5_core: Call synchronize_irq() before freeing EQ buffer
After destroying the EQ, the object responsible for generating interrupts, call
synchronize_irq() to ensure that any handler routines running on other CPU
cores finish execution. Only then free the EQ buffer. This patch solves a very
rare case when we get panic on driver unload.
The same thing is done when we destroy a CQ which is one of the sources
generating interrupts. In the case of CQ we want to avoid completion handlers
on a CQ that was destroyed. In the case we do the same to avoid receiving
asynchronous events after the EQ has been destroyed and its buffers freed.
Signed-off-by: Eli Cohen <eli@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/mellanox/mlx5/core/eq.c')
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlx5/core/eq.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eq.c b/drivers/net/ethernet/mellanox/mlx5/core/eq.c index ed53291..a278238 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/eq.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/eq.c @@ -420,6 +420,7 @@ int mlx5_destroy_unmap_eq(struct mlx5_core_dev *dev, struct mlx5_eq *eq) if (err) mlx5_core_warn(dev, "failed to destroy a previously created eq: eqn %d\n", eq->eqn); + synchronize_irq(table->msix_arr[eq->irqn].vector); mlx5_buf_free(dev, &eq->buf); return err; |