diff options
| author | Julia Lawall <julia.lawall@lip6.fr> | 2015-08-23 00:11:16 (GMT) |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-08-25 20:37:31 (GMT) |
| commit | 5c12197939be10c117039aabc06830297fb6d6ee (patch) | |
| tree | 5e9d6618b6dbba1e15cb5e55cd088ce29a593a4f /drivers/net/ethernet/mellanox/mlxsw | |
| parent | 1ef53ebfa9ff5b205604fc781868765e00ae875f (diff) | |
| download | linux-5c12197939be10c117039aabc06830297fb6d6ee.tar.xz | |
mlxsw: fix error return code
Return a negative error code on failure.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/mellanox/mlxsw')
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlxsw/pci.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/ethernet/mellanox/mlxsw/pci.c b/drivers/net/ethernet/mellanox/mlxsw/pci.c index a34f474..045f98f 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/pci.c +++ b/drivers/net/ethernet/mellanox/mlxsw/pci.c @@ -1726,6 +1726,7 @@ static int mlxsw_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) mlxsw_pci_dbg_root); if (!mlxsw_pci->dbg_dir) { dev_err(&pdev->dev, "Failed to create debugfs dir\n"); + err = -ENOMEM; goto err_dbg_create_dir; } |