diff options
| author | stephen hemminger <stephen@networkplumber.org> | 2017-01-07 03:12:52 (GMT) |
|---|---|---|
| committer | Xie Xiaobo <xiaobo.xie@nxp.com> | 2017-07-14 10:08:26 (GMT) |
| commit | 923c0029ee72bfd78a331f6d0df788a40a9178a1 (patch) | |
| tree | afa4c5eda2144abb7b09654dcfae12d7cb7f6ace /drivers/net/macvlan.c | |
| parent | 95b8bbff6ecf0692747622af16d917a67313f8cc (diff) | |
| download | linux-923c0029ee72bfd78a331f6d0df788a40a9178a1.tar.xz | |
net: make ndo_get_stats64 a void function
The network device operation for reading statistics is only called
in one place, and it ignores the return value. Having a structure
return value is potentially confusing because some future driver could
incorrectly assume that the return value was used.
Fix all drivers with ndo_get_stats64 to have a void function.
Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/macvlan.c')
| -rw-r--r-- | drivers/net/macvlan.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index dc8ccac..9457614 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -857,8 +857,8 @@ static void macvlan_uninit(struct net_device *dev) macvlan_port_destroy(port->dev); } -static struct rtnl_link_stats64 *macvlan_dev_get_stats64(struct net_device *dev, - struct rtnl_link_stats64 *stats) +static void macvlan_dev_get_stats64(struct net_device *dev, + struct rtnl_link_stats64 *stats) { struct macvlan_dev *vlan = netdev_priv(dev); @@ -895,7 +895,6 @@ static struct rtnl_link_stats64 *macvlan_dev_get_stats64(struct net_device *dev, stats->rx_dropped = rx_errors; stats->tx_dropped = tx_dropped; } - return stats; } static int macvlan_vlan_rx_add_vid(struct net_device *dev, |