diff options
author | Wolfram Sang <w.sang@pengutronix.de> | 2009-11-16 12:57:49 (GMT) |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-11-17 11:54:02 (GMT) |
commit | 68bd7422a2e07a4e5502137cd4bddb8c2774a912 (patch) | |
tree | 0f42eee1a2057ddc18264df99b4d881e62bff6a7 /drivers/net | |
parent | 1712fe59415faf23a36c38dbacf18efd4ffe94e0 (diff) | |
download | linux-68bd7422a2e07a4e5502137cd4bddb8c2774a912.tar.xz |
net/can/mscan: drop assignment in while-construct
As suggested by Wolfgang Grandegger.
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
-rw-r--r-- | drivers/net/can/mscan/mscan.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/net/can/mscan/mscan.c b/drivers/net/can/mscan/mscan.c index 76e413e..20d1991 100644 --- a/drivers/net/can/mscan/mscan.c +++ b/drivers/net/can/mscan/mscan.c @@ -379,8 +379,10 @@ static int mscan_rx_poll(struct napi_struct *napi, int quota) struct can_frame *frame; u8 canrflg; - while (npackets < quota && ((canrflg = in_8(®s->canrflg)) & - (MSCAN_RXF | MSCAN_ERR_IF))) { + while (npackets < quota) { + canrflg = in_8(®s->canrflg); + if (!(canrflg & (MSCAN_RXF | MSCAN_ERR_IF))) + break; skb = alloc_can_skb(dev, &frame); if (!skb) { |