diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2015-12-21 16:39:48 (GMT) |
---|---|---|
committer | Linus Walleij <linus.walleij@linaro.org> | 2015-12-22 12:49:05 (GMT) |
commit | 4fc8a4b2a4dd7704d950a01b1afec5e86af60565 (patch) | |
tree | 34d80c8cb8a5d0bdff4ceb0b33fb6da11762521d /drivers/pinctrl/mediatek | |
parent | f7a81b7f4e9830323a7bbee8c4c7ab4c7c7ff6f4 (diff) | |
download | linux-4fc8a4b2a4dd7704d950a01b1afec5e86af60565.tar.xz |
pinctrl: mediatek: add missing of_node_put
for_each_child_of_node performs an of_node_get on each iteration, so a
return from the loop requires an of_node_put.
A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr):
// <smpl>
@@
local idexpression n;
expression e,e1;
@@
for_each_child_of_node(e1,n) {
...
(
of_node_put(n);
|
e = n
|
return n;
|
+ of_node_put(n);
? return ...;
)
...
}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/mediatek')
-rw-r--r-- | drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c index 8db7cdf..e22cbaf 100644 --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c @@ -598,6 +598,7 @@ static int mtk_pctrl_dt_node_to_map(struct pinctrl_dev *pctldev, &reserved_maps, num_maps); if (ret < 0) { pinctrl_utils_dt_free_map(pctldev, *map, *num_maps); + of_node_put(np); return ret; } } |