summaryrefslogtreecommitdiff
path: root/drivers/platform
diff options
context:
space:
mode:
authorMichał Kępień <kernel@kempniu.pl>2016-01-22 14:27:19 (GMT)
committerDarren Hart <dvhart@linux.intel.com>2016-03-23 17:05:40 (GMT)
commitc42831c8a9db32a5a0e2c6c31042014039f11739 (patch)
treed7da6500e8043fedf0831a9bd0700911a1ec3eb9 /drivers/platform
parent17070f242aa989c33b227e61ea060f768a77f2dc (diff)
downloadlinux-c42831c8a9db32a5a0e2c6c31042014039f11739.tar.xz
dell-smbios: don't return an SMBIOS buffer from dell_smbios_send_request()
An SMBIOS buffer pointer does not need to be returned by dell_smbios_send_request(), because SMBIOS call results are stored in the buffer exported by the module. Signed-off-by: Michał Kępień <kernel@kempniu.pl> Reviewed-by: Pali Rohár <pali.rohar@gmail.com> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
Diffstat (limited to 'drivers/platform')
-rw-r--r--drivers/platform/x86/dell-smbios.c5
-rw-r--r--drivers/platform/x86/dell-smbios.h3
2 files changed, 2 insertions, 6 deletions
diff --git a/drivers/platform/x86/dell-smbios.c b/drivers/platform/x86/dell-smbios.c
index ac1cbed..9dacb20 100644
--- a/drivers/platform/x86/dell-smbios.c
+++ b/drivers/platform/x86/dell-smbios.c
@@ -60,8 +60,7 @@ void dell_smbios_release_buffer(void)
}
EXPORT_SYMBOL_GPL(dell_smbios_release_buffer);
-struct calling_interface_buffer *
-dell_smbios_send_request(int class, int select)
+void dell_smbios_send_request(int class, int select)
{
struct smi_cmd command;
@@ -75,8 +74,6 @@ dell_smbios_send_request(int class, int select)
buffer->select = select;
dcdbas_smi_request(&command);
-
- return buffer;
}
EXPORT_SYMBOL_GPL(dell_smbios_send_request);
diff --git a/drivers/platform/x86/dell-smbios.h b/drivers/platform/x86/dell-smbios.h
index 4220ac1..80b5048 100644
--- a/drivers/platform/x86/dell-smbios.h
+++ b/drivers/platform/x86/dell-smbios.h
@@ -41,8 +41,7 @@ extern struct calling_interface_token *da_tokens;
void dell_smbios_get_buffer(void);
void dell_smbios_clear_buffer(void);
void dell_smbios_release_buffer(void);
-struct calling_interface_buffer *
-dell_smbios_send_request(int class, int select);
+void dell_smbios_send_request(int class, int select);
int find_token_id(int tokenid);
int find_token_location(int tokenid);