diff options
| author | Manoj Kumar <kumarmn@us.ibm.com> | 2015-10-21 20:11:00 (GMT) |
|---|---|---|
| committer | James Bottomley <JBottomley@Odin.com> | 2015-10-30 07:57:55 (GMT) |
| commit | 3ebf203093b4ee07d62ef1a02dbbf7a293770388 (patch) | |
| tree | 0740b929e699e3098a677755b80a199a08b1e858 /drivers/scsi/cxlflash/vlun.c | |
| parent | fa4aa632da19fba0154b66a50329acd738304291 (diff) | |
| download | linux-3ebf203093b4ee07d62ef1a02dbbf7a293770388.tar.xz | |
cxlflash: Replace magic numbers with literals
Magic numbers are not meaningful and can create confusion. As a
remedy, replace them with descriptive literals.
Replace 512 with literal MAX_SECTOR_UNIT.
Replace 5 with literal CMD_RETRIES.
Signed-off-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
Signed-off-by: Manoj N. Kumar <manoj@linux.vnet.ibm.com>
Reviewed-by: Brian King <brking@linux.vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Signed-off-by: James Bottomley <JBottomley@Odin.com>
Diffstat (limited to 'drivers/scsi/cxlflash/vlun.c')
| -rw-r--r-- | drivers/scsi/cxlflash/vlun.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/scsi/cxlflash/vlun.c b/drivers/scsi/cxlflash/vlun.c index 6155cb1..6d6608b 100644 --- a/drivers/scsi/cxlflash/vlun.c +++ b/drivers/scsi/cxlflash/vlun.c @@ -434,7 +434,8 @@ static int write_same16(struct scsi_device *sdev, &scsi_cmd[10]); result = scsi_execute(sdev, scsi_cmd, DMA_TO_DEVICE, cmd_buf, - CMD_BUFSIZE, sense_buf, tout, 5, 0, NULL); + CMD_BUFSIZE, sense_buf, tout, CMD_RETRIES, + 0, NULL); if (result) { dev_err_ratelimited(dev, "%s: command failed for " "offset %lld result=0x%x\n", |