diff options
| author | James Bottomley <jejb@titanic.(none)> | 2005-08-28 16:31:14 (GMT) |
|---|---|---|
| committer | James Bottomley <jejb@titanic.(none)> | 2005-08-28 16:31:14 (GMT) |
| commit | 33aa687db90dd8541bd5e9a762eebf880eaee767 (patch) | |
| tree | dac741e1f3f43a1de2433a21b874a093783717f3 /drivers/scsi/scsi_error.c | |
| parent | 1cf72699c1530c3e4ac3d58344f6a6a40a2f46d3 (diff) | |
| download | linux-33aa687db90dd8541bd5e9a762eebf880eaee767.tar.xz | |
[SCSI] convert SPI transport class to scsi_execute
This one's slightly more difficult. The transport class uses
REQ_FAILFAST, so another interface (scsi_execute) had to be invented to
take the extra flag. Also, the sense functions are shifted around to
allow spi_execute to place data directly into a struct scsi_sense_hdr.
With this change, there's probably a lot of unnecessary sense buffer
allocation going on which we can fix later.
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'drivers/scsi/scsi_error.c')
| -rw-r--r-- | drivers/scsi/scsi_error.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c index e9c451b..2686d56 100644 --- a/drivers/scsi/scsi_error.c +++ b/drivers/scsi/scsi_error.c @@ -1847,12 +1847,16 @@ EXPORT_SYMBOL(scsi_reset_provider); int scsi_normalize_sense(const u8 *sense_buffer, int sb_len, struct scsi_sense_hdr *sshdr) { - if (!sense_buffer || !sb_len || (sense_buffer[0] & 0x70) != 0x70) + if (!sense_buffer || !sb_len) return 0; memset(sshdr, 0, sizeof(struct scsi_sense_hdr)); sshdr->response_code = (sense_buffer[0] & 0x7f); + + if (!scsi_sense_valid(sshdr)) + return 0; + if (sshdr->response_code >= 0x72) { /* * descriptor format |