diff options
| author | James Bottomley <JBottomley@Odin.com> | 2015-04-26 18:52:46 (GMT) |
|---|---|---|
| committer | James Bottomley <JBottomley@Odin.com> | 2015-05-25 15:46:24 (GMT) |
| commit | ef10b16948bc0db51a0140be5109ad73b170a011 (patch) | |
| tree | e25e3557892e8c698036bf5d2233d14c640a03fd /drivers/scsi/scsi_scan.c | |
| parent | 32505876c0947a4cecc409dfbef1fc58ced6138d (diff) | |
| download | linux-ef10b16948bc0db51a0140be5109ad73b170a011.tar.xz | |
scsi_scan: fix queue depth initialisation problem
Currently we blindly use the value of cmd_per_lun as the initial setting for
queue_depth. This fails miserably (hangs the system) if it is zero, which is
the default value for anything uninitialised in the template. The net result
is that every host template has to set a value for cmd_per_lun. Instead, use
a default value of 1 if the actual value is unset. This should pave the way
for removing cmd_per_lun from all the templates and eventually from SCSI
itself.
Signed-off-by: James Bottomley <JBottomley@Odin.com>
Diffstat (limited to 'drivers/scsi/scsi_scan.c')
| -rw-r--r-- | drivers/scsi/scsi_scan.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index 6efab1c..53a2e33 100644 --- a/drivers/scsi/scsi_scan.c +++ b/drivers/scsi/scsi_scan.c @@ -280,7 +280,8 @@ static struct scsi_device *scsi_alloc_sdev(struct scsi_target *starget, sdev->host->cmd_per_lun, shost->bqt, shost->hostt->tag_alloc_policy); } - scsi_change_queue_depth(sdev, sdev->host->cmd_per_lun); + scsi_change_queue_depth(sdev, sdev->host->cmd_per_lun ? + sdev->host->cmd_per_lun : 1); scsi_sysfs_device_initialize(sdev); |