diff options
| author | James Bottomley <JBottomley@Parallels.com> | 2014-04-10 20:36:11 (GMT) |
|---|---|---|
| committer | James Bottomley <JBottomley@Parallels.com> | 2014-04-21 21:28:40 (GMT) |
| commit | c69e6f812bab0d5442b40e2f1bfbca48d40bc50b (patch) | |
| tree | 52b69dc5e7d7883d01117947d48bc63dcb115fab /drivers/scsi | |
| parent | 7daf480483e60898f30e0a2a84fecada7a7cfac0 (diff) | |
| download | linux-c69e6f812bab0d5442b40e2f1bfbca48d40bc50b.tar.xz | |
[SCSI] More USB deadlock fixes
This patch fixes a corner case in the previous USB Deadlock fix patch (12023e7
[SCSI] Fix USB deadlock caused by SCSI error handling).
The scenario is abort command, set flag, abort completes, send TUR, TUR
doesn't return, so we now try to abort the TUR, but scsi_abort_eh_cmnd()
will skip the abort because the flag is set and move straight to reset.
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'drivers/scsi')
| -rw-r--r-- | drivers/scsi/scsi_error.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c index ad064d2..f17aa7a 100644 --- a/drivers/scsi/scsi_error.c +++ b/drivers/scsi/scsi_error.c @@ -921,6 +921,7 @@ void scsi_eh_prep_cmnd(struct scsi_cmnd *scmd, struct scsi_eh_save *ses, ses->prot_op = scmd->prot_op; scmd->prot_op = SCSI_PROT_NORMAL; + scmd->eh_eflags = 0; scmd->cmnd = ses->eh_cmnd; memset(scmd->cmnd, 0, BLK_MAX_CDB); memset(&scmd->sdb, 0, sizeof(scmd->sdb)); |