diff options
| author | Kristina Martšenko <kristina.martsenko@gmail.com> | 2014-03-14 23:10:05 (GMT) |
|---|---|---|
| committer | Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> | 2014-03-17 02:53:58 (GMT) |
| commit | 8943a92fc257c439ffe55fb0f9896be57c58c56b (patch) | |
| tree | b6685bd14b534665cf9b4df6d71730c7f0f7dfc0 /drivers/staging/gdm72xx/gdm_usb.c | |
| parent | 4db02435652dad3233d347c0ba6d9dece8ff791a (diff) | |
| download | linux-8943a92fc257c439ffe55fb0f9896be57c58c56b.tar.xz | |
staging: gdm72xx: replace printk() and debug macros with dynamic debugging
Replace printk(KERN_DEBUG ...) with netdev_dbg and dev_dbg. Remove
debug macros which become unnecessary.
This removes the following types of checkpatch warnings from the driver:
drivers/staging/gdm72xx/gdm_sdio.c:461: WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ...
Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Diffstat (limited to 'drivers/staging/gdm72xx/gdm_usb.c')
| -rw-r--r-- | drivers/staging/gdm72xx/gdm_usb.c | 13 |
1 files changed, 2 insertions, 11 deletions
diff --git a/drivers/staging/gdm72xx/gdm_usb.c b/drivers/staging/gdm72xx/gdm_usb.c index ff0e573..20539d8 100644 --- a/drivers/staging/gdm72xx/gdm_usb.c +++ b/drivers/staging/gdm72xx/gdm_usb.c @@ -55,8 +55,6 @@ static int k_mode_stop; static int init_usb(struct usbwm_dev *udev); static void release_usb(struct usbwm_dev *udev); -/*#define DEBUG */ - static struct usb_tx *alloc_tx_struct(struct tx_cxt *tx) { struct usb_tx *t = kzalloc(sizeof(*t), GFP_ATOMIC); @@ -423,10 +421,7 @@ static void gdm_usb_rcv_complete(struct urb *urb) struct usb_tx *t; u16 cmd_evt; unsigned long flags, flags2; - -#ifdef CONFIG_WIMAX_GDM72XX_USB_PM struct usb_device *dev = urb->dev; -#endif /* Completion by usb_unlink_urb */ if (urb->status == -ECONNRESET) @@ -440,15 +435,11 @@ static void gdm_usb_rcv_complete(struct urb *urb) r->buf, urb->actual_length, false); if (cmd_evt == WIMAX_SDU_TX_FLOW) { if (r->buf[4] == 0) { -#ifdef DEBUG - printk(KERN_DEBUG "WIMAX ==> STOP SDU TX\n"); -#endif + dev_dbg(&dev->dev, "WIMAX ==> STOP SDU TX\n"); list_for_each_entry(t, &tx->sdu_list, list) usb_unlink_urb(t->urb); } else if (r->buf[4] == 1) { -#ifdef DEBUG - printk(KERN_DEBUG "WIMAX ==> START SDU TX\n"); -#endif + dev_dbg(&dev->dev, "WIMAX ==> START SDU TX\n"); list_for_each_entry(t, &tx->sdu_list, list) { usb_submit_urb(t->urb, GFP_ATOMIC); } |