summaryrefslogtreecommitdiff
path: root/drivers/target
diff options
context:
space:
mode:
authorSagi Grimberg <sagig@mellanox.com>2014-04-29 10:13:45 (GMT)
committerNicholas Bellinger <nab@linux-iscsi.org>2014-05-16 00:09:10 (GMT)
commit531b7bf4bd795d9a09eac92504322a472c010bc8 (patch)
tree2dfdac4bae9215493c6c293d9e638a6436bfb526 /drivers/target
parent9fe63c88b1d59f1ce054d6948ccd3096496ecedb (diff)
downloadlinux-531b7bf4bd795d9a09eac92504322a472c010bc8.tar.xz
Target/iser: Fix iscsit_accept_np and rdma_cm racy flow
RDMA CM and iSCSI target flows are asynchronous and completely uncorrelated. Relying on the fact that iscsi_accept_np will be called after CM connection request event and will wait for it is a mistake. When attempting to login to a few targets this flow is racy and unpredictable, but for parallel login to dozens of targets will race and hang every time. The correct synchronizing mechanism in this case is pending on a semaphore rather than a wait_for_event. We keep the pending interruptible for iscsi_np cleanup stage. (Squash patch to remove dead code into parent - nab) Reported-by: Slava Shwartsman <valyushash@gmail.com> Signed-off-by: Sagi Grimberg <sagig@mellanox.com> Cc: stable@vger.kernel.org # 3.10+ Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/target')
0 files changed, 0 insertions, 0 deletions