summaryrefslogtreecommitdiff
path: root/drivers/thermal/armada_thermal.c
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2016-09-09 20:10:45 (GMT)
committerGuenter Roeck <linux@roeck-us.net>2016-09-09 21:54:53 (GMT)
commitc7cefce03e691270c0e5e117248e14661e9c9cad (patch)
treeac1c49d2f0d85bbba473455c741fbd47806d20a3 /drivers/thermal/armada_thermal.c
parentc0a4b9ec1b43ebb9d5001e3bf86f58d4ca0ffe18 (diff)
downloadlinux-c7cefce03e691270c0e5e117248e14661e9c9cad.tar.xz
hwmon: (xgene) access mailbox as RAM
The newly added hwmon driver fails to build in an allmodconfig kernel: ERROR: "memblock_is_memory" [drivers/hwmon/xgene-hwmon.ko] undefined! According to comments in the code, the mailbox is a shared memory region, not a set of MMIO registers, so we should use memremap() for mapping it instead of ioremap or acpi_os_ioremap, and pointer dereferences instead of readl/writel. The driver already uses plain kernel pointers, so it's a bit unusual to work with functions that operate on __iomem pointers, and this fixes that part too. I'm using READ_ONCE/WRITE_ONCE here to keep the existing behavior regarding the ordering of the accesses from the CPU, but note that there are no barriers (also unchanged from before). I'm also keeping the endianness behavior, though I'm unsure whether the message data was supposed to be in LE32 format in the first place, it's possible this was meant to be interpreted as a byte stream instead. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Acked-by: Hoan Tran <hotran@apm.com> Tested-by: Hoan Tran <hotran@apm.com> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/thermal/armada_thermal.c')
0 files changed, 0 insertions, 0 deletions