diff options
author | Peter Hurley <peter@hurleysoftware.com> | 2014-11-05 17:12:49 (GMT) |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-11-06 02:24:10 (GMT) |
commit | 55199ea3bd2e53007715d544fb9094cbbdda1597 (patch) | |
tree | 89f757f6bdb5d7b421d4c099ca70b73eb62c64b1 /drivers/tty/tty_io.c | |
parent | 216030ec55e08646be629ee32725c0189ad74c9a (diff) | |
download | linux-55199ea3bd2e53007715d544fb9094cbbdda1597.tar.xz |
pty: Always return -EIO if slave BSD pty opened first
Opening the slave BSD pty first already returns -EIO from the slave
pty_open(), which in turn causes the newly installed tty pair to be
released before returning from tty_open(). However, this can also
cause a parallel master BSD pty open to fail because the pty pair
destruction may already been taking place in tty_release().
Failing at driver->install() if the slave pty is opened first ensures
that a pty master open cannot fail, because the driver tables will
not have been updated so tty_driver_lookup_tty() won't find the
master pty (and attempt to "re-open" it).
In turn, this guarantees that any tty with a tty->count == 0 is
in final close (rather than never opened).
Reviewed-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty/tty_io.c')
0 files changed, 0 insertions, 0 deletions