diff options
| author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2014-07-20 03:41:53 (GMT) |
|---|---|---|
| committer | Felipe Balbi <balbi@ti.com> | 2014-08-19 14:27:24 (GMT) |
| commit | 4b11f88821aff3e780cb3eac3a48270551e41167 (patch) | |
| tree | 4277de7e92e5b33e0fc7259bbd7508c5797c64aa /drivers/usb/gadget | |
| parent | 7042e8f2f6f5c76b6173748570312bbeb044c7dd (diff) | |
| download | linux-4b11f88821aff3e780cb3eac3a48270551e41167.tar.xz | |
usb: gadget: Fix return value check in r8a66597_probe()
In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().
Acked-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'drivers/usb/gadget')
| -rw-r--r-- | drivers/usb/gadget/udc/r8a66597-udc.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/usb/gadget/udc/r8a66597-udc.c b/drivers/usb/gadget/udc/r8a66597-udc.c index 4600842..de2a871 100644 --- a/drivers/usb/gadget/udc/r8a66597-udc.c +++ b/drivers/usb/gadget/udc/r8a66597-udc.c @@ -1868,8 +1868,8 @@ static int r8a66597_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); reg = devm_ioremap_resource(&pdev->dev, res); - if (!reg) - return -ENODEV; + if (IS_ERR(reg)) + return PTR_ERR(reg); ires = platform_get_resource(pdev, IORESOURCE_IRQ, 0); irq = ires->start; |