diff options
| author | Felipe Balbi <balbi@ti.com> | 2015-12-10 19:08:20 (GMT) |
|---|---|---|
| committer | Felipe Balbi <balbi@ti.com> | 2015-12-16 16:07:27 (GMT) |
| commit | 95ca961c758cd9ce789247098b09c39017637e58 (patch) | |
| tree | ab592e351593daddcfa530ecad149449bfb18668 /drivers/usb | |
| parent | 855ed04a3758b205e84b269f92d26ab36ed8e2f7 (diff) | |
| download | linux-95ca961c758cd9ce789247098b09c39017637e58.tar.xz | |
usb: dwc3: gadget: pass a condition to dev_WARN_ONCE()
instead of using:
if (condition) {
dev_WARN_ONCE(dev, true, "foo");
return -EINVAL;
}
let's use:
if (dev_WARN_ONCE(dev, condition, "foo"))
return -EINVAL;
Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'drivers/usb')
| -rw-r--r-- | drivers/usb/dwc3/gadget.c | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 9758018..64b2a83 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -661,11 +661,10 @@ static int dwc3_gadget_ep_enable(struct usb_ep *ep, dep = to_dwc3_ep(ep); dwc = dep->dwc; - if (dep->flags & DWC3_EP_ENABLED) { - dev_WARN_ONCE(dwc->dev, true, "%s is already enabled\n", - dep->name); + if (dev_WARN_ONCE(dwc->dev, dep->flags & DWC3_EP_ENABLED, + "%s is already enabled\n", + dep->name)) return 0; - } spin_lock_irqsave(&dwc->lock, flags); ret = __dwc3_gadget_ep_enable(dep, desc, ep->comp_desc, false, false); @@ -689,11 +688,10 @@ static int dwc3_gadget_ep_disable(struct usb_ep *ep) dep = to_dwc3_ep(ep); dwc = dep->dwc; - if (!(dep->flags & DWC3_EP_ENABLED)) { - dev_WARN_ONCE(dwc->dev, true, "%s is already disabled\n", - dep->name); + if (dev_WARN_ONCE(dwc->dev, !(dep->flags & DWC3_EP_ENABLED), + "%s is already disabled\n", + dep->name)) return 0; - } spin_lock_irqsave(&dwc->lock, flags); ret = __dwc3_gadget_ep_disable(dep); |