diff options
| author | Krzysztof Helt <krzysztof.h1@wp.pl> | 2009-12-16 00:46:25 (GMT) |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-12-16 15:20:01 (GMT) |
| commit | 2f390380ca69e1617cdddb12d8da94f0a9f4319d (patch) | |
| tree | 2f60b69e62e099c43a90197c62704f099ad2169e /drivers/video/pmag-ba-fb.c | |
| parent | 2cb96f86628d6e97fcbda5fe4d8d74876239834c (diff) | |
| download | linux-2f390380ca69e1617cdddb12d8da94f0a9f4319d.tar.xz | |
fbdev: add palette register check to several drivers
Add check if palette register number is in correct range for few drivers
which miss it. The regno value comes indirectly from user space.
Two drivers has converted check from BUG_ON() macro to just return an
error (non-zero value).
Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/video/pmag-ba-fb.c')
| -rw-r--r-- | drivers/video/pmag-ba-fb.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/video/pmag-ba-fb.c b/drivers/video/pmag-ba-fb.c index 0573ec6..0f361b6 100644 --- a/drivers/video/pmag-ba-fb.c +++ b/drivers/video/pmag-ba-fb.c @@ -98,7 +98,8 @@ static int pmagbafb_setcolreg(unsigned int regno, unsigned int red, { struct pmagbafb_par *par = info->par; - BUG_ON(regno >= info->cmap.len); + if (regno >= info->cmap.len) + return 1; red >>= 8; /* The cmap fields are 16 bits */ green >>= 8; /* wide, but the hardware colormap */ |