diff options
| author | H Hartley Sweeten <hsweeten@visionengravers.com> | 2015-03-04 19:15:33 (GMT) |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-03-07 00:01:28 (GMT) |
| commit | 5effdf708100fd5eeeaa8c7bbbed3b90cbb70cf5 (patch) | |
| tree | e0cffb26162362b73450eae9ba3f8f29f7ba2d6b /drivers | |
| parent | 854472c27046646f3f258970a9fee9ab1e5d7593 (diff) | |
| download | linux-5effdf708100fd5eeeaa8c7bbbed3b90cbb70cf5.tar.xz | |
staging: comedi: mite: (!foo) preferred over (foo == NULL)
Also, clarify the 'ring' allocation failure by returning NULL instead
of 'ring' (which would be NULL).
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/staging/comedi/drivers/mite.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/staging/comedi/drivers/mite.c b/drivers/staging/comedi/drivers/mite.c index 1e537a5..79b5597 100644 --- a/drivers/staging/comedi/drivers/mite.c +++ b/drivers/staging/comedi/drivers/mite.c @@ -186,10 +186,10 @@ struct mite_dma_descriptor_ring *mite_alloc_ring(struct mite_struct *mite) struct mite_dma_descriptor_ring *ring = kmalloc(sizeof(struct mite_dma_descriptor_ring), GFP_KERNEL); - if (ring == NULL) - return ring; + if (!ring) + return NULL; ring->hw_dev = get_device(&mite->pcidev->dev); - if (ring->hw_dev == NULL) { + if (!ring->hw_dev) { kfree(ring); return NULL; } |