summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorCamelia Groza <camelia.groza@nxp.com>2017-10-18 13:38:30 (GMT)
committerXie Xiaobo <xiaobo.xie@nxp.com>2017-12-12 07:32:32 (GMT)
commitc5b821fabb0b6282a6a90d3f40d256244bbf0057 (patch)
treed3c3c417c23e2917673f2e113c4f096d80629012 /drivers
parentc628b6501fd4cbcc01ce7914ffba79d2d8005236 (diff)
downloadlinux-c5b821fabb0b6282a6a90d3f40d256244bbf0057.tar.xz
sdk_dpaa: accept frames on RX even if larger than MTU
Documentation/networking/netdevices.txt mentions that interfaces must be able to receive frames at least the size of the configured MTU. The behavior for received frames larger than the MTU is unspecified. We have been dropping these frames in software. Remove this behavior and accept them. Signed-off-by: Camelia Groza <camelia.groza@nxp.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/net/ethernet/freescale/sdk_dpaa/dpaa_eth.h11
-rw-r--r--drivers/net/ethernet/freescale/sdk_dpaa/dpaa_eth_sg.c11
2 files changed, 0 insertions, 22 deletions
diff --git a/drivers/net/ethernet/freescale/sdk_dpaa/dpaa_eth.h b/drivers/net/ethernet/freescale/sdk_dpaa/dpaa_eth.h
index b1703bc..57c9bef 100644
--- a/drivers/net/ethernet/freescale/sdk_dpaa/dpaa_eth.h
+++ b/drivers/net/ethernet/freescale/sdk_dpaa/dpaa_eth.h
@@ -514,17 +514,6 @@ dpa_fd_offset(const struct qm_fd *fd)
return fd->offset;
}
-/* Verifies if the skb length is below the interface MTU */
-static inline int dpa_check_rx_mtu(struct sk_buff *skb, int mtu)
-{
- if (unlikely(skb->len > mtu))
- if ((skb->protocol != htons(ETH_P_8021Q))
- || (skb->len > mtu + 4))
- return -1;
-
- return 0;
-}
-
static inline uint16_t dpa_get_headroom(struct dpa_buffer_layout_s *bl)
{
uint16_t headroom;
diff --git a/drivers/net/ethernet/freescale/sdk_dpaa/dpaa_eth_sg.c b/drivers/net/ethernet/freescale/sdk_dpaa/dpaa_eth_sg.c
index 11b47e8..32e62e6 100644
--- a/drivers/net/ethernet/freescale/sdk_dpaa/dpaa_eth_sg.c
+++ b/drivers/net/ethernet/freescale/sdk_dpaa/dpaa_eth_sg.c
@@ -616,13 +616,6 @@ void __hot _dpa_rx(struct net_device *net_dev,
(*count_ptr)--;
skb->protocol = eth_type_trans(skb, net_dev);
- /* IP Reassembled frames are allowed to be larger than MTU */
- if (unlikely(dpa_check_rx_mtu(skb, net_dev->mtu) &&
- !(fd_status & FM_FD_IPR))) {
- percpu_stats->rx_dropped++;
- goto drop_bad_frame;
- }
-
skb_len = skb->len;
#ifdef CONFIG_FSL_DPAA_DBG_LOOP
@@ -655,10 +648,6 @@ void __hot _dpa_rx(struct net_device *net_dev,
packet_dropped:
return;
-drop_bad_frame:
- dev_kfree_skb(skb);
- return;
-
_release_frame:
dpa_fd_release(net_dev, fd);
}