diff options
| author | Greg KH <gregkh@suse.de> | 2005-08-18 00:33:11 (GMT) |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2005-08-18 05:02:25 (GMT) |
| commit | 518e6540831c69422faecceee8f964bd439ac9d0 (patch) | |
| tree | 0b31e27c6007adac51c8e6e3a832badc1d8e2a1a /drivers | |
| parent | 099d44e869f1886b5eb02a5145ca97b5e4142e28 (diff) | |
| download | linux-518e6540831c69422faecceee8f964bd439ac9d0.tar.xz | |
[PATCH] Fix manual binding infinite loop
Fix for manual binding of drivers to devices. Problem is if you pass in
a valid device id, but the driver refuses to bind. Infinite loop as
write() tries to resubmit the data it just sent.
Thanks to Michal Ostrowski <mostrows@watson.ibm.com> for pointing the
problem out.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/base/bus.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/base/bus.c b/drivers/base/bus.c index 96fe2f9..ab53832 100644 --- a/drivers/base/bus.c +++ b/drivers/base/bus.c @@ -180,7 +180,9 @@ static ssize_t driver_bind(struct device_driver *drv, up(&dev->sem); put_device(dev); } - return err; + if (err) + return err; + return count; } static DRIVER_ATTR(bind, S_IWUSR, NULL, driver_bind); |