diff options
author | Eric Dumazet <edumazet@google.com> | 2013-11-08 02:32:06 (GMT) |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-11-08 07:07:59 (GMT) |
commit | dcd607718385d02ce3741de225927a57f528f93b (patch) | |
tree | 48dcb0b8e4a43c92d9ca90bfb4fdcb4482af159f /drivers | |
parent | 0b2e2d36d152a94082f05ad226a290d765ffb7d2 (diff) | |
download | linux-dcd607718385d02ce3741de225927a57f528f93b.tar.xz |
inet: fix a UFO regression
While testing virtio_net and skb_segment() changes, Hannes reported
that UFO was sending wrong frames.
It appears this was introduced by a recent commit :
8c3a897bfab1 ("inet: restore gso for vxlan")
The old condition to perform IP frag was :
tunnel = !!skb->encapsulation;
...
if (!tunnel && proto == IPPROTO_UDP) {
So the new one should be :
udpfrag = !skb->encapsulation && proto == IPPROTO_UDP;
...
if (udpfrag) {
Initialization of udpfrag must be done before call
to ops->callbacks.gso_segment(skb, features), as
skb_udp_tunnel_segment() clears skb->encapsulation
(We want udpfrag to be true for UFO, false for VXLAN)
With help from Alexei Starovoitov
Reported-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Alexei Starovoitov <ast@plumgrid.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
0 files changed, 0 insertions, 0 deletions