diff options
| author | David S. Miller <davem@davemloft.net> | 2008-07-21 15:34:49 (GMT) |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2008-07-21 15:34:49 (GMT) |
| commit | fd24c4af6e82231391fa09875ae6378fa1399f0f (patch) | |
| tree | 0fddd1b5b1fe7e13013e61e0e050d2751b8f1168 /drivers | |
| parent | ebbdbd7c02f4f8dea84e2956aa942bd18e1ddf93 (diff) | |
| download | linux-fd24c4af6e82231391fa09875ae6378fa1399f0f.tar.xz | |
sunhme: Remove stop/wake TX queue calls in set-multicast-list handler.
Based upon a bug report by Alexander Beregalov and commentary
from Ben Hutchings.
These are totally unnecessary, in particular because this
driver's ->hard_start_xmit() handler takes the same driver
spinlock that the set-multicast-list handler uses.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/sunhme.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/net/sunhme.c b/drivers/net/sunhme.c index 1aa425b..b79d5f0 100644 --- a/drivers/net/sunhme.c +++ b/drivers/net/sunhme.c @@ -2377,8 +2377,6 @@ static void happy_meal_set_multicast(struct net_device *dev) spin_lock_irq(&hp->happy_lock); - netif_stop_queue(dev); - if ((dev->flags & IFF_ALLMULTI) || (dev->mc_count > 64)) { hme_write32(hp, bregs + BMAC_HTABLE0, 0xffff); hme_write32(hp, bregs + BMAC_HTABLE1, 0xffff); @@ -2410,8 +2408,6 @@ static void happy_meal_set_multicast(struct net_device *dev) hme_write32(hp, bregs + BMAC_HTABLE3, hash_table[3]); } - netif_wake_queue(dev); - spin_unlock_irq(&hp->happy_lock); } |