summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorfrançois romieu <romieu@fr.zoreil.com>2009-06-17 11:43:11 (GMT)
committerDavid S. Miller <davem@davemloft.net>2009-06-18 01:46:46 (GMT)
commitc2f3f3a2fe4e35db352cfe1176e384e36bfd91b1 (patch)
tree28abad21db7632288692371f62d8c47108bfeeaa /drivers
parentfb1001f3de1a8576b25d929502f1fe7865ff32dc (diff)
downloadlinux-c2f3f3a2fe4e35db352cfe1176e384e36bfd91b1.tar.xz
sis190: use an adequate phy list entry as a fallback
When sis190 driver is trying to get default phy, if it doesn't find home or lan phy, it falls back to the first phy in the phy list but list_entry() points to a bogus entry. list_first_entry() should be used instead. Signed-off-by: Arnaud Patard <apatard@mandriva.com> Acked-off-by: Francois Romieu <romieu@fr.zoreil.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/net/sis190.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c
index e224766..1f040e8 100644
--- a/drivers/net/sis190.c
+++ b/drivers/net/sis190.c
@@ -1281,7 +1281,7 @@ static u16 sis190_default_phy(struct net_device *dev)
else if (phy_lan)
phy_default = phy_lan;
else
- phy_default = list_entry(&tp->first_phy,
+ phy_default = list_first_entry(&tp->first_phy,
struct sis190_phy, list);
}