diff options
author | Sudip Mukherjee <sudipm.mukherjee@gmail.com> | 2015-09-05 13:43:43 (GMT) |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-09-13 01:24:53 (GMT) |
commit | eb6a2dbf32a4ea2fa94f742f6494f661a807fb45 (patch) | |
tree | 132bdd39824b67dd9b0638fc5a8c0080c27675e9 /drivers | |
parent | e1b32e1e89ee69fd62e6d3bd781d017748889e00 (diff) | |
download | linux-eb6a2dbf32a4ea2fa94f742f6494f661a807fb45.tar.xz |
staging: fbtft: use strncpy instead of strcpy
Using strcpy() is a security risk as the destination buffer size is not
checked and we may over-run the buffer. Use strncpy() instead, while
mentioning the buffer size leaving place for the NULL termination.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/staging/fbtft/fbtft_device.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c index 0483d33..3856c88 100644 --- a/drivers/staging/fbtft/fbtft_device.c +++ b/drivers/staging/fbtft/fbtft_device.c @@ -1342,7 +1342,8 @@ static int __init fbtft_device_init(void) p_name, p_num); return -EINVAL; } - strcpy(fbtft_device_param_gpios[i].name, p_name); + strncpy(fbtft_device_param_gpios[i].name, p_name, + FBTFT_GPIO_NAME_SIZE - 1); fbtft_device_param_gpios[i++].gpio = (int) val; if (i == MAX_GPIOS) { pr_err(DRVNAME |