diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2015-10-10 12:30:50 (GMT) |
---|---|---|
committer | Lee Jones <lee.jones@linaro.org> | 2015-10-15 11:06:21 (GMT) |
commit | f85de2d9e24ee0b286ae54434f405d4a22f565f0 (patch) | |
tree | f7f208781b75f840f9a2396cbb3a9e8ebb1ca0ae /drivers | |
parent | 7111c6c672fc8714c5092952a24df6694d46d71f (diff) | |
download | linux-f85de2d9e24ee0b286ae54434f405d4a22f565f0.tar.xz |
backlight: 88pm860x_bl: Add missing of_node_put
for_each_child_of_node performs an of_node_get on each iteration, so
a break out of the loop requires an of_node_put.
The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr):
// <smpl>
@@
expression root,e;
local idexpression child;
iterator name for_each_child_of_node;
@@
for_each_child_of_node(root, child) {
... when != of_node_put(child)
when != e = child
+ of_node_put(child);
? break;
...
}
... when != child
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/video/backlight/88pm860x_bl.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/video/backlight/88pm860x_bl.c b/drivers/video/backlight/88pm860x_bl.c index 2da5862..6d8dc2c 100644 --- a/drivers/video/backlight/88pm860x_bl.c +++ b/drivers/video/backlight/88pm860x_bl.c @@ -180,6 +180,7 @@ static int pm860x_backlight_dt_init(struct platform_device *pdev, data->iset = PM8606_WLED_CURRENT(iset); of_property_read_u32(np, "marvell,88pm860x-pwm", &data->pwm); + of_node_put(np); break; } } |