diff options
| author | Josef Bacik <josef@redhat.com> | 2012-06-08 19:26:47 (GMT) |
|---|---|---|
| committer | Chris Mason <chris.mason@oracle.com> | 2012-06-15 01:30:54 (GMT) |
| commit | 7ddf5a42d311d74fd9f7373cb56def0843c219f8 (patch) | |
| tree | 3b6a46eec858b867db9184d0e8beefe4ed01e9ec /fs/btrfs/btrfs_inode.h | |
| parent | 8180ef8894fa402443205cff1e23417e8d3434df (diff) | |
| download | linux-7ddf5a42d311d74fd9f7373cb56def0843c219f8.tar.xz | |
Btrfs: call filemap_fdatawrite twice for compression
I removed this in an earlier commit and I was wrong. Because compression
can return from filemap_fdatawrite() without having actually set any of it's
pages as writeback() it can make filemap_fdatawait() do essentially nothing,
and then we won't find any ordered extents because they may not have been
created yet. So not only does this make fsync() completely useless, but it
will also screw up if you truncate on a non-page aligned offset since we
zero out the end and then wait on ordered extents and then call drop caches.
We can drop the cache before the io completes and then we try to unpin the
extent we just wrote we won't find it and everything goes sideways. So fix
this by putting it back and put a giant comment there to keep me from trying
to remove it in the future. Thanks,
Signed-off-by: Josef Bacik <josef@redhat.com>
Diffstat (limited to 'fs/btrfs/btrfs_inode.h')
| -rw-r--r-- | fs/btrfs/btrfs_inode.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/btrfs/btrfs_inode.h b/fs/btrfs/btrfs_inode.h index e616f887..12394a9 100644 --- a/fs/btrfs/btrfs_inode.h +++ b/fs/btrfs/btrfs_inode.h @@ -37,6 +37,7 @@ #define BTRFS_INODE_IN_DEFRAG 3 #define BTRFS_INODE_DELALLOC_META_RESERVED 4 #define BTRFS_INODE_HAS_ORPHAN_ITEM 5 +#define BTRFS_INODE_HAS_ASYNC_EXTENT 6 /* in memory btrfs inode */ struct btrfs_inode { |