diff options
author | Filipe Manana <fdmanana@suse.com> | 2015-11-19 11:45:48 (GMT) |
---|---|---|
committer | Chris Mason <clm@fb.com> | 2015-11-25 13:22:08 (GMT) |
commit | 758f2dfcf8a249b1f1510aa32e625c2ec20642a3 (patch) | |
tree | a521154fb1e3384087e4a828197f69eca158d280 /fs/btrfs/dev-replace.h | |
parent | 020d5b7366fc03e4bf84142ae6f63031ac504e33 (diff) | |
download | linux-758f2dfcf8a249b1f1510aa32e625c2ec20642a3.tar.xz |
Btrfs: fix scrub preventing unused block groups from being deleted
Currently scrub can race with the cleaner kthread when the later attempts
to delete an unused block group, and the result is preventing the cleaner
kthread from ever deleting later the block group - unless the block group
becomes used and unused again. The following diagram illustrates that
race:
CPU 1 CPU 2
cleaner kthread
btrfs_delete_unused_bgs()
gets block group X from
fs_info->unused_bgs and
removes it from that list
scrub_enumerate_chunks()
searches device tree using
its commit root
finds device extent for
block group X
gets block group X from the tree
fs_info->block_group_cache_tree
(via btrfs_lookup_block_group())
sets bg X to RO
sees the block group is
already RO and therefore
doesn't delete it nor adds
it back to unused list
So fix this by making scrub add the block group again to the list of
unused block groups if the block group is still unused when it finished
scrubbing it and it hasn't been removed already.
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: Chris Mason <clm@fb.com>
Diffstat (limited to 'fs/btrfs/dev-replace.h')
0 files changed, 0 insertions, 0 deletions