summaryrefslogtreecommitdiff
path: root/fs/fuse
diff options
context:
space:
mode:
authorChris Mason <clm@fb.com>2015-02-17 21:46:07 (GMT)
committerLinus Torvalds <torvalds@linux-foundation.org>2015-02-17 22:34:52 (GMT)
commite22553e2a25ed3f2a9c874088e0f20cdcd97c7b0 (patch)
tree134114516dc3fa8418a6b8a1829fae8279d4d754 /fs/fuse
parent7647f14fe4cd98151f8e90656c01fe61044de714 (diff)
downloadlinux-e22553e2a25ed3f2a9c874088e0f20cdcd97c7b0.tar.xz
eventfd: don't take the spinlock in eventfd_poll
The spinlock in eventfd_poll is trying to protect the count of events so it can decide if it should return POLLIN, POLLERR, or POLLOUT. But, because of the way we drop the lock after calling poll_wait, and drop it again before returning, we have the same pile of races with the lock as we do with a single read of ctx->count(). This replaces the lock with a read barrier and single read. eventfd_write does a single bump of ctx->count, so this should not add new races with adding events. eventfd_read is similar, it will do a single decrement with the lock held, and so we're making the race with concurrent readers slightly larger. This spinlock is the top CPU user in kernel code during one of our workloads. Removing it gives us a ~2% boost. [arnd@arndb.de: avoid unused variable warning] [dan.carpenter@oracle.com: type bug in eventfd_poll()] Signed-off-by: Chris Mason <clm@fb.com> Cc: Davide Libenzi <davidel@xmailserver.org> Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/fuse')
0 files changed, 0 insertions, 0 deletions