diff options
author | Takashi Iwai <tiwai@suse.de> | 2016-02-04 16:06:13 (GMT) |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2016-02-04 16:19:09 (GMT) |
commit | 094fd3be87b0f102589e2d5c3fa5d06b7e20496d (patch) | |
tree | 4c03e57b6d246496a84fe5bf47c88c32db3a4768 /fs/logfs/inode.c | |
parent | 2e5dc73fe1c4befaf894ca357edb5443b82148b1 (diff) | |
download | linux-094fd3be87b0f102589e2d5c3fa5d06b7e20496d.tar.xz |
ALSA: timer: Fix leftover link at closing
In ALSA timer core, the active timer instance is managed in
active_list linked list. Each element is added / removed dynamically
at timer start, stop and in timer interrupt. The problem is that
snd_timer_interrupt() has a thinko and leaves the element in
active_list when it's the last opened element. This eventually leads
to list corruption or use-after-free error.
This hasn't been revealed because we used to delete the list forcibly
in snd_timer_stop() in the past. However, the recent fix avoids the
double-stop behavior (in commit [f784beb75ce8: ALSA: timer: Fix link
corruption due to double start or stop]), and this leak hits reality.
This patch fixes the link management in snd_timer_interrupt(). Now it
simply unlinks no matter which stream is.
BugLink: http://lkml.kernel.org/r/CACT4Y+Yy2aukHP-EDp8-ziNqNNmb-NTf=jDWXMP7jB8HDa2vng@mail.gmail.com
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'fs/logfs/inode.c')
0 files changed, 0 insertions, 0 deletions