diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2016-02-28 00:17:33 (GMT) |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2016-02-28 00:17:33 (GMT) |
commit | c80567c82ae4814a41287618e315a60ecf513be6 (patch) | |
tree | 34f4ef5e692f6667c9659332b56ebb09732a7534 /fs/namei.c | |
parent | 0fcbf996d848d03573113d83f4e3fb3bcfa5ab5e (diff) | |
download | linux-c80567c82ae4814a41287618e315a60ecf513be6.tar.xz |
do_last(): don't let a bogus return value from ->open() et.al. to confuse us
... into returning a positive to path_openat(), which would interpret that
as "symlink had been encountered" and proceed to corrupt memory, etc.
It can only happen due to a bug in some ->open() instance or in some LSM
hook, etc., so we report any such event *and* make sure it doesn't trick
us into further unpleasantness.
Cc: stable@vger.kernel.org # v3.6+, at least
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/namei.c')
-rw-r--r-- | fs/namei.c | 4 |
1 files changed, 4 insertions, 0 deletions
@@ -3273,6 +3273,10 @@ opened: goto exit_fput; } out: + if (unlikely(error > 0)) { + WARN_ON(1); + error = -EINVAL; + } if (got_write) mnt_drop_write(nd->path.mnt); path_put(&save_parent); |