diff options
author | Ben Pfaff <blp@nicira.com> | 2014-07-09 17:31:22 (GMT) |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-07-09 21:33:47 (GMT) |
commit | ac30ef832e6af0505b6f0251a6659adcfa74975e (patch) | |
tree | 8a65858cef97946794e8ac01e3f82405a85643bb /fs | |
parent | 0a1985879437d14bda8c90d0dae3455c467d7642 (diff) | |
download | linux-ac30ef832e6af0505b6f0251a6659adcfa74975e.tar.xz |
netlink: Fix handling of error from netlink_dump().
netlink_dump() returns a negative errno value on error. Until now,
netlink_recvmsg() directly recorded that negative value in sk->sk_err, but
that's wrong since sk_err takes positive errno values. (This manifests as
userspace receiving a positive return value from the recv() system call,
falsely indicating success.) This bug was introduced in the commit that
started checking the netlink_dump() return value, commit b44d211 (netlink:
handle errors from netlink_dump()).
Multithreaded Netlink dumps are one way to trigger this behavior in
practice, as described in the commit message for the userspace workaround
posted here:
http://openvswitch.org/pipermail/dev/2014-June/042339.html
This commit also fixes the same bug in netlink_poll(), introduced in commit
cd1df525d (netlink: add flow control for memory mapped I/O).
Signed-off-by: Ben Pfaff <blp@nicira.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'fs')
0 files changed, 0 insertions, 0 deletions