diff options
author | AnilKumar Ch <anilkumar@ti.com> | 2012-05-23 12:15:09 (GMT) |
---|---|---|
committer | Marc Kleine-Budde <mkl@pengutronix.de> | 2012-06-03 16:59:18 (GMT) |
commit | 617caccebe451716df21c069b079d5936ed7b0f3 (patch) | |
tree | 48e896e5da53154401eaaf406229e2f42f1c7519 /include/asm-generic/pgalloc.h | |
parent | 9ca3cc6f3026946ba655e863ca2096339e667639 (diff) | |
download | linux-617caccebe451716df21c069b079d5936ed7b0f3.tar.xz |
can: c_can: fix "BUG! echo_skb is occupied!" during transmit
This patch fixes an issue with transmit routine, which causes
"can_put_echo_skb: BUG! echo_skb is occupied!" message when
using "cansequence -p" on D_CAN controller.
In c_can driver, while transmitting packets tx_echo flag holds
the no of can frames put for transmission into the hardware.
As the comment above c_can_do_tx() indicates, if we find any packet
which is not transmitted then we should stop looking for more.
In the current implementation this is not taken care of causing the
said message.
Also, fix the condition used to find if the packet is transmitted
or not. Current code skips the first tx message object and ends up
checking one extra invalid object.
While at it, fix the comment on top of c_can_do_tx() to use the
terminology "packet" instead of "package" since it is more
standard.
Cc: stable@kernel.org # 2.6.39+
Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
Acked-by: Wolfgang Grandegger <wg@grandegger.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Diffstat (limited to 'include/asm-generic/pgalloc.h')
0 files changed, 0 insertions, 0 deletions