diff options
| author | Eric Dumazet <edumazet@google.com> | 2015-03-18 01:32:31 (GMT) |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-03-18 02:02:29 (GMT) |
| commit | 0470c8ca1d57927f2cc3e1d5add1fb2834609447 (patch) | |
| tree | 798f475f48fbdff0eae359c3f345a1a0eaf83ca2 /include/net/inet_sock.h | |
| parent | e3d95ad7da4f8955599f0786d7c70497c0aaf8c9 (diff) | |
| download | linux-0470c8ca1d57927f2cc3e1d5add1fb2834609447.tar.xz | |
inet: fix request sock refcounting
While testing last patch series, I found req sock refcounting was wrong.
We must set skc_refcnt to 1 for all request socks added in hashes,
but also on request sockets created by FastOpen or syncookies.
It is tricky because we need to defer this initialization so that
future RCU lookups do not try to take a refcount on a not yet
fully initialized request socket.
Also get rid of ireq_refcnt alias.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Fixes: 13854e5a6046 ("inet: add proper refcounting to request sock")
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/net/inet_sock.h')
| -rw-r--r-- | include/net/inet_sock.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/include/net/inet_sock.h b/include/net/inet_sock.h index 6fec734..b6c3737 100644 --- a/include/net/inet_sock.h +++ b/include/net/inet_sock.h @@ -81,7 +81,6 @@ struct inet_request_sock { #define ir_cookie req.__req_common.skc_cookie #define ireq_net req.__req_common.skc_net #define ireq_state req.__req_common.skc_state -#define ireq_refcnt req.__req_common.skc_refcnt #define ireq_family req.__req_common.skc_family kmemcheck_bitfield_begin(flags); |