summaryrefslogtreecommitdiff
path: root/include/xen
diff options
context:
space:
mode:
authorMark Brown <broonie@kernel.org>2016-03-30 16:29:36 (GMT)
committerTomi Valkeinen <tomi.valkeinen@ti.com>2016-08-11 14:54:52 (GMT)
commit1d1e56f4140d0af98f7c232fa315e010cd532ccc (patch)
tree866696dedf7d7c4df847a84f1a7b5bd57960a79f /include/xen
parent29b4817d4018df78086157ea3a55c1d9424a7cfc (diff)
downloadlinux-1d1e56f4140d0af98f7c232fa315e010cd532ccc.tar.xz
omapfb: Fix regulator API abuse in dss.c and hdmi4/5.c
The voltage changing code in this driver is broken and should be removed. The driver sets a single, exact voltage on probe. Unless there is a very good reason for this (which should be documented in comments) constraints like this need to be set via the machine constraints, voltage setting in a driver is expected to be used in cases where the voltage varies at runtime. In addition client drivers should almost never be calling regulator_can_set_voltage(), if the device needs to set a voltage it needs to set the voltage and the regulator core will handle the case where the regulator is fixed voltage. If the driver can skip setting the voltage it should just never set the voltage. Signed-off-by: Mark Brown <broonie@kernel.org> [tomi.valkeinen@ti.com: fix abuse in hdmi5.c too] Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Diffstat (limited to 'include/xen')
0 files changed, 0 insertions, 0 deletions