diff options
author | Brian King <brking@linux.vnet.ibm.com> | 2010-09-10 07:03:21 (GMT) |
---|---|---|
committer | Jens Axboe <jaxboe@fusionio.com> | 2010-09-10 07:03:21 (GMT) |
commit | be14eb619108fa8b7120eb2c42d66d5f623ae10e (patch) | |
tree | cfc8a496c62a429a97c4bc2c5e638c39374f560b /include | |
parent | edce6820a9fdda85521211cb334a183e34cc455e (diff) | |
download | linux-be14eb619108fa8b7120eb2c42d66d5f623ae10e.tar.xz |
block: Range check cpu in blk_cpu_to_group
While testing CPU DLPAR, the following problem was discovered.
We were DLPAR removing the first CPU, which in this case was
logical CPUs 0-3. CPUs 0-2 were already marked offline and
we were in the process of offlining CPU 3. After marking
the CPU inactive and offline in cpu_disable, but before the
cpu was completely idle (cpu_die), we ended up in __make_request
on CPU 3. There we looked at the topology map to see which CPU
to complete the I/O on and found no CPUs in the cpu_sibling_map.
This resulted in the block layer setting the completion cpu
to be NR_CPUS, which then caused an oops when we tried to
complete the I/O.
Fix this by sanity checking the value we return from blk_cpu_to_group
to be a valid cpu value.
Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions