diff options
| author | Jiri Pirko <jiri@mellanox.com> | 2017-09-13 15:32:37 (GMT) |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-10-12 09:51:20 (GMT) |
| commit | f86d3b1a28a7271774fe4e8a9a028f6b209e1fd3 (patch) | |
| tree | a3b997583020092fdd5dcbf90d213f0e461c8796 /include | |
| parent | f860ca549de4670e95516d6e7cbbc733a69c63db (diff) | |
| download | linux-f86d3b1a28a7271774fe4e8a9a028f6b209e1fd3.tar.xz | |
net: sched: fix use-after-free in tcf_action_destroy and tcf_del_walker
[ Upstream commit 255cd50f207ae8ec7b22663246c833407744e634 ]
Recent commit d7fb60b9cafb ("net_sched: get rid of tcfa_rcu") removed
freeing in call_rcu, which changed already existing hard-to-hit
race condition into 100% hit:
[ 598.599825] BUG: unable to handle kernel NULL pointer dereference at 0000000000000030
[ 598.607782] IP: tcf_action_destroy+0xc0/0x140
Or:
[ 40.858924] BUG: unable to handle kernel NULL pointer dereference at 0000000000000030
[ 40.862840] IP: tcf_generic_walker+0x534/0x820
Fix this by storing the ops and use them directly for module_put call.
Fixes: a85a970af265 ("net_sched: move tc_action into tcf_common")
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions