diff options
author | Michael S. Tsirkin <mst@redhat.com> | 2012-04-09 00:24:02 (GMT) |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-04-13 17:09:19 (GMT) |
commit | ca8f4fb21d08747013cce9cf1840aa5bfc31f2d8 (patch) | |
tree | f18de0412ec64d7aa4a26ff85d0ad1c57263dbff /include | |
parent | 9a5d2bd99e0dfe9a31b3c160073ac445ba3d773f (diff) | |
download | linux-ca8f4fb21d08747013cce9cf1840aa5bfc31f2d8.tar.xz |
skbuff: struct ubuf_info callback type safety
The skb struct ubuf_info callback gets passed struct ubuf_info
itself, not the arg value as the field name and the function signature
seem to imply. Rename the arg field to ctx to match usage,
add documentation and change the callback argument type
to make usage clear and to have compiler check correctness.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include')
-rw-r--r-- | include/linux/skbuff.h | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 70a3f8d..775292a 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -238,11 +238,12 @@ enum { /* * The callback notifies userspace to release buffers when skb DMA is done in * lower device, the skb last reference should be 0 when calling this. - * The desc is used to track userspace buffer index. + * The ctx field is used to track device context. + * The desc field is used to track userspace buffer index. */ struct ubuf_info { - void (*callback)(void *); - void *arg; + void (*callback)(struct ubuf_info *); + void *ctx; unsigned long desc; }; |