summaryrefslogtreecommitdiff
path: root/ipc
diff options
context:
space:
mode:
authorGregory Bean <gbean@codeaurora.org>2010-09-09 23:38:02 (GMT)
committerLinus Torvalds <torvalds@linux-foundation.org>2010-09-10 01:57:24 (GMT)
commit5affb607720d734ca572b8a77c5c7d62d3042b6f (patch)
tree5c3a675bef03570958fc4e9baffb318ec7f64e31 /ipc
parent0dcc48c15f63ee86c2fcd33968b08d651f0360a5 (diff)
downloadlinux-5affb607720d734ca572b8a77c5c7d62d3042b6f.tar.xz
gpio: sx150x: correct and refine reset-on-probe behavior
Replace the arbitrary software-reset call from the device-probe method, because: - It is defective. To work correctly, it should be two byte writes, not a single word write. As it stands, it does nothing. - Some devices with sx150x expanders installed have their NRESET pins ganged on the same line, so resetting one causes the others to reset - not a nice thing to do arbitrarily! - The probe, usually taking place at boot, implies a recent hard-reset, so a software reset at this point is just a waste of energy anyway. Therefore, make it optional, defaulting to off, as this will match the common case of probing at powerup and also matches the current broken no-op behavior. Signed-off-by: Gregory Bean <gbean@codeaurora.org> Reviewed-by: Jean Delvare <khali@linux-fr.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'ipc')
0 files changed, 0 insertions, 0 deletions