diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2012-08-19 07:02:53 (GMT) |
---|---|---|
committer | Mark Brown <broonie@opensource.wolfsonmicro.com> | 2012-08-20 19:44:28 (GMT) |
commit | b18e93a493626c1446f9788ebd5844d008bbf71c (patch) | |
tree | b65825976f6e63b8a4a47c38dc875f1e7d623143 /ipc | |
parent | db8b624d55e65ad5d8211a9fef66fa7f16bd13a0 (diff) | |
download | linux-b18e93a493626c1446f9788ebd5844d008bbf71c.tar.xz |
ASoC: ux500_msp_i2s: better use devm functions and fix error return code
Remove unnecessary calls to devm_kfree and replace iounmap by devm_iounmap
(and use resource_size for the third argument). These changes make it
possible to remove the error-handling code at the end of
ux500_msp_i2s_init_msp, and all of the gotos become direct returns.
In the case of the second call to devm_kzalloc, the return variable ret was
not initialized. Here it is changed to a direct return of -ENOMEM.
A simplified version of the semantic match that finds the second problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Diffstat (limited to 'ipc')
0 files changed, 0 insertions, 0 deletions