summaryrefslogtreecommitdiff
path: root/lib/bcd.c
diff options
context:
space:
mode:
authorDave Chinner <dchinner@redhat.com>2013-05-21 08:02:00 (GMT)
committerBen Myers <bpm@sgi.com>2013-05-21 18:57:05 (GMT)
commitf648167f3ac79018c210112508c732ea9bf67c7b (patch)
tree29ceb96b625f9841dfad5633cff25dded3ef2ad6 /lib/bcd.c
parente461fcb194172b3f709e0b478d2ac1bdac7ab9a3 (diff)
downloadlinux-f648167f3ac79018c210112508c732ea9bf67c7b.tar.xz
xfs: avoid nesting transactions in xfs_qm_scall_setqlim()
Lockdep reports: ============================================= [ INFO: possible recursive locking detected ] 3.9.0+ #3 Not tainted --------------------------------------------- setquota/28368 is trying to acquire lock: (sb_internal){++++.?}, at: [<c11e8846>] xfs_trans_alloc+0x26/0x50 but task is already holding lock: (sb_internal){++++.?}, at: [<c11e8846>] xfs_trans_alloc+0x26/0x50 from xfs_qm_scall_setqlim()->xfs_dqread() when a dquot needs to be allocated. xfs_qm_scall_setqlim() is starting a transaction and then not passing it into xfs_qm_dqet() and so it starts it's own transaction when allocating the dquot. Splat! Fix this by not allocating the dquot in xfs_qm_scall_setqlim() inside the setqlim transaction. This requires getting the dquot first (and allocating it if necessary) then dropping and relocking the dquot before joining it to the setqlim transaction. Reported-by: Michael L. Semon <mlsemon35@gmail.com> Signed-off-by: Dave Chinner <dchinner@redhat.com> Reviewed-by: Ben Myers <bpm@sgi.com> Signed-off-by: Ben Myers <bpm@sgi.com>
Diffstat (limited to 'lib/bcd.c')
0 files changed, 0 insertions, 0 deletions