diff options
| author | Johannes Berg <johannes@sipsolutions.net> | 2009-04-22 09:25:43 (GMT) |
|---|---|---|
| committer | John W. Linville <linville@tuxdriver.com> | 2009-04-22 20:57:20 (GMT) |
| commit | 1d4df3a50f40a731fc03c86a76535ed141b0e4bc (patch) | |
| tree | 6d0867c4f48a2df93cc6854d33e98d5e8165b0fe /lib/int_sqrt.c | |
| parent | eb1a685e07310b5137c561e25ab738292db2c8a5 (diff) | |
| download | linux-1d4df3a50f40a731fc03c86a76535ed141b0e4bc.tar.xz | |
mac80211: fix variable truncation on 32-bit
Stephen Rothwell reported these warnings from a 32-bit build:
net/mac80211/mlme.c:1771: warning: left shift count >= width of type
net/mac80211/mlme.c:1772: warning: left shift count >= width of type
net/mac80211/mlme.c:1773: warning: left shift count >= width of type
net/mac80211/mlme.c:1774: warning: left shift count >= width of type
net/mac80211/mlme.c:1775: warning: left shift count >= width of type
This shows a bug in my code -- BIT(X) uses just "1 << X" which means
a 32-bit integer on 32-bit platforms, but the code here needs a u64
on all platforms. Fix this by using "1ULL << X" instead of BIT(X).
Thanks Stephen!
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'lib/int_sqrt.c')
0 files changed, 0 insertions, 0 deletions